Fixed "Culprit" recording in Sentry

[slightfoot]

Fix stack-trace frame ordering. In order for Culprit to be logged correctly it should have the latest frame at the top.

[slightfoot]

@yjbanov I run the Dart tests locally and they all succeed with Dart 2. The Travis error looks to be related to typing and Dart 2. Perhaps you can take a look.

[yjbanov]

Thanks for the fix! Are there any docs that describe how culprit works? I'm also wondering if populating it explicitly here is a more robust way to go?

[slightfoot]

It's more about how the Sentry site displays the culprit. It's wrong without the stack in reverse. This is probably more to do with the fact that Sentry doesn't 'officially' support Dart. In which case they might automatically reverse it.

This snippet will show you my implementation.
https://gist.github.com/slightfoot/094657bb22e986bbb4c9bafd9841cbd8

[yjbanov]

Ok, looks like the only way to know for sure is to try it. I can't think of anything that would break from this change other than surprise some people when they see the stacks reversed. So let's give it a shot. Let me look into the type errors first.

[slightfoot]

@yjbanov once this is merged and the package released. I can push out my crash reporting solution.

[yjbanov]

FYI #15 hopefully fixes the type issue 🤞

[yjbanov]

Could you please rebase this PR on top of tip of tree? If it's green on Travis let's merge it.

[slightfoot]

@yjbanov rebased, any ideas on the travis issue?

[yjbanov]

Hmm, it's as if part of the log file is missing. I restarted the job in case it was a flake.

[yjbanov]

Oh wait, you just need to dartfmt -w test/sentry_test.dart

[yjbanov]

Thanks for fixing this! Merging. I'll do a release shortly.

[slightfoot]

Thanks @yjbanov.