Skip to content

Commit

Permalink
chore(replay): Cleanup package.json scripts (#6348)
Browse files Browse the repository at this point in the history
Clean up the replay integration's `package.json` by getting rid of a few ToDos, enabling the circular dependency check and using the eslint cache of the monorepo. 

Since the future of the demo app in the replay package is still unclear, I opted to repurpose and rename the `bootstrap` script so that it now only bootstraps the demo app. For the package itself, bootstrapping happens via a monorepo-level `yarn` command or `lerna bootstrap` command.
  • Loading branch information
Lms24 authored Nov 30, 2022
1 parent 15b344f commit 57bf5c3
Showing 1 changed file with 4 additions and 6 deletions.
10 changes: 4 additions & 6 deletions packages/replay/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
"types": "build/npm/types/src/index.d.ts",
"sideEffects": false,
"scripts": {
"bootstrap": "yarn && cd demo && yarn #TODO: change after migration",
"build:rollup": "run-s build:worker build:core",
"build": "run-s build:worker && run-p build:core build:types",
"build:dev": "run-s build #TODO adjust after adding CDN bundles",
Expand All @@ -18,19 +17,18 @@
"build:dev:watch": "yarn build:watch #TODO adjust after adding CDN bundles",
"build:types:watch": "tsc -p tsconfig.types.json --watch",
"build:npm": "ts-node ../../scripts/prepack.ts --bundles && npm pack ./build/npm",
"circularDepCheck": "#TODO comment in after migration: madge --circular src/index.ts",
"circularDepCheck": "madge --circular src/index.ts",
"clean": "rimraf build sentry-replay-*.tgz",
"fix": "run-s fix:eslint fix:prettier",
"fix:eslint": "eslint . --format stylish --fix",
"fix:prettier": "prettier --write \"{src,test,scripts,worker}/**/*.ts\"",
"lint": "run-s lint:prettier lint:eslint",
"lint:eslint": "eslint . --format stylish #TODO: we might want to use eslintcache after migration",
"lint:eslint": "eslint . --cache --cache-location '../../eslintcache/' --format stylish",
"lint:prettier": "prettier --check \"{src,test,scripts,worker}/**/*.ts\"",
"test": "jest",
"test:watch": "jest --watch",
"start:demo": "yarn build:dev && cd demo && yarn start",
"build:prod": "yarn build #TODO remove, we don't need this anymore after migration",
"dev": "yarn build:dev:watch #TODO remove, we don't need this anymore after migration"
"bootstrap:demo": "cd demo && yarn",
"start:demo": "yarn build:dev && cd demo && yarn start"
},
"repository": {
"type": "git",
Expand Down

0 comments on commit 57bf5c3

Please sign in to comment.