Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(otel): Set otel span on scope #6349

Closed
wants to merge 1 commit into from

Conversation

AbhiPrasad
Copy link
Member

This allows us to link errors to transactions via contexts.trace

This allows us to link errors to transactions via contexts.trace
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.57 KB (-0.03% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 60.59 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.36 KB (+0.01% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 54.15 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 20.12 KB (0%)
@sentry/browser - Webpack (minified) 65.75 KB (0%)
@sentry/react - Webpack (gzipped + minified) 20.14 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 45.99 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.44 KB (-0.02% 🔽)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 24.87 KB (+0.02% 🔺)
@sentry/replay index.js 62 KB (0%)
@sentry/replay - Webpack (gzipped + minified) 62 KB (0%)
@sentry/replay - Webpack (minified) 199.35 KB (0%)

@AbhiPrasad
Copy link
Member Author

After discussion with the team, we've decided to use event processor for this to avoid using scope.

Here's how this will work. In the event processor we'll

  1. Check for current otel span
  2. Grab it's trace info
  3. Add it to error events the same way we do in event processing

@AbhiPrasad AbhiPrasad closed this Dec 1, 2022
@AbhiPrasad AbhiPrasad deleted the abhi-set-otel-span-on-scope branch December 1, 2022 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants