Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utility function/decorator to mark things as Sentry-patched #3375

Open
szokeasaurusrex opened this issue Jul 30, 2024 · 0 comments
Open

Utility function/decorator to mark things as Sentry-patched #3375

szokeasaurusrex opened this issue Jul 30, 2024 · 0 comments

Comments

@szokeasaurusrex
Copy link
Member

szokeasaurusrex commented Jul 30, 2024

While reviewing #3358, I had the idea that we might want to make it easier to detect when the SDK has already patched something. This came up because with the @ensure_integration_enabled decorator, the function's __name__ (and similar attributes) are overwritten to make the function look like the original function, so we cannot use these attributes to detect that a function has been patched by Sentry. I originally thought adding this would be necessary for that PR to work, but turns out we don't need it, so I am documenting this idea here, instead.

We could add this to the @ensure_integration_enabled decorator and/or make a separate decorator. The decorator would set an attribute called something like _sentry_patched on the patched function/class/etc. We could set this attribute simply to True, or if we want to make it more informative, maybe we can include some information about what patched the function (maybe the integration class/identifier – we can think about what would be the most helpful).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant