Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(profiling): profiler_id uses underscore #3249

Merged
merged 2 commits into from
Jul 8, 2024

Conversation

Zylphrex
Copy link
Member

@Zylphrex Zylphrex commented Jul 4, 2024

Relay expects this with an underscore instead of a dot.

Relay expects this with an underscore instead of a dot.
Copy link

codecov bot commented Jul 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.74%. Comparing base (6701616) to head (5660e9e).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3249      +/-   ##
==========================================
- Coverage   79.33%   78.74%   -0.60%     
==========================================
  Files         132      132              
  Lines       14217    14362     +145     
  Branches     2984     3040      +56     
==========================================
+ Hits        11279    11309      +30     
- Misses       2093     2205     +112     
- Partials      845      848       +3     
Files Coverage Δ
sentry_sdk/consts.py 90.86% <100.00%> (ø)
sentry_sdk/tracing.py 73.54% <ø> (ø)

... and 4 files with indirect coverage changes

@Zylphrex Zylphrex marked this pull request as ready for review July 5, 2024 18:27
@sentrivana sentrivana enabled auto-merge (squash) July 8, 2024 07:42
@sentrivana sentrivana merged commit 32335dd into master Jul 8, 2024
122 checks passed
@sentrivana sentrivana deleted the txiao/fix/profiler-id-uses-underscore branch July 8, 2024 07:51
arjennienhuis pushed a commit to arjennienhuis/sentry-python that referenced this pull request Sep 30, 2024
Relay expects this with an underscore instead of a dot.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants