Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add http_methods_to_capture to ASGI Django #3607

Merged
merged 4 commits into from
Oct 4, 2024

Conversation

sentrivana
Copy link
Contributor

@sentrivana sentrivana commented Oct 3, 2024

The ASGI middleware already supports this, we just weren't passing the option in.

Copy link

codecov bot commented Oct 3, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 84.36%. Comparing base (033e3ad) to head (93055fb).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
sentry_sdk/integrations/django/asgi.py 25.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3607   +/-   ##
=======================================
  Coverage   84.36%   84.36%           
=======================================
  Files         133      133           
  Lines       13927    13929    +2     
  Branches     2937     2937           
=======================================
+ Hits        11749    11751    +2     
- Misses       1441     1442    +1     
+ Partials      737      736    -1     
Files with missing lines Coverage Δ
sentry_sdk/integrations/django/asgi.py 87.37% <25.00%> (-0.75%) ⬇️

... and 3 files with indirect coverage changes

Copy link
Member

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay!

@sentrivana sentrivana enabled auto-merge (squash) October 4, 2024 08:26
@sentrivana sentrivana merged commit 55d757a into master Oct 4, 2024
134 of 135 checks passed
@sentrivana sentrivana deleted the ivana/http-methods-asgi-django branch October 4, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants