Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds breadcrumb origin field #4124

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

Adds breadcrumb origin field #4124

wants to merge 11 commits into from
+11 −0

Conversation

antonis
Copy link
Collaborator

@antonis antonis commented Sep 27, 2024 •
edited
Loading

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Uses breadcrumb.origin field to prevent exception capture context from being overwritten by native scope sync

Depends on:

💡 Motivation and Context

Fixes #2146
The discussion in getsentry/sentry-capacitor#629 (comment) adds some context on the need of a new field to be used internally to solve a technical problem.

💚 How did you test it?

TODO

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • All tests passing
  • No breaking changes

🔮 Next steps

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 8, 2024 •
edited
Loading

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1214.38 ms 1221.65 ms 7.27 ms
Size 2.36 MiB 3.10 MiB 752.44 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
abb7058+dirty 1255.42 ms 1268.86 ms 13.44 ms
e540498+dirty 1220.61 ms 1212.93 ms -7.68 ms
d43a46b+dirty 1219.24 ms 1219.65 ms 0.41 ms
0677344+dirty 1276.70 ms 1300.07 ms 23.37 ms
148f924+dirty 1214.76 ms 1215.73 ms 0.97 ms
700cbf4+dirty 1234.59 ms 1227.71 ms -6.88 ms
22e31b6+dirty 1253.62 ms 1265.96 ms 12.34 ms
5bb8d5f+dirty 1235.47 ms 1237.39 ms 1.92 ms
e73d82f+dirty 1207.52 ms 1216.73 ms 9.21 ms
70e6261+dirty 1220.09 ms 1230.04 ms 9.95 ms

App size

Revision Plain With Sentry Diff
abb7058+dirty 2.36 MiB 2.87 MiB 520.42 KiB
e540498+dirty 2.36 MiB 3.14 MiB 793.34 KiB
d43a46b+dirty 2.36 MiB 3.08 MiB 734.25 KiB
0677344+dirty 2.36 MiB 2.85 MiB 496.81 KiB
148f924+dirty 2.36 MiB 3.04 MiB 696.25 KiB
700cbf4+dirty 2.36 MiB 3.08 MiB 734.22 KiB
22e31b6+dirty 2.36 MiB 2.87 MiB 520.67 KiB
5bb8d5f+dirty 2.36 MiB 2.92 MiB 570.22 KiB
e73d82f+dirty 2.36 MiB 3.08 MiB 734.23 KiB
70e6261+dirty 2.36 MiB 3.03 MiB 680.42 KiB

Previous results on branch: antonis/add-breadcrumb-origin

Startup times

Revision Plain With Sentry Diff
e62bf30+dirty 1238.96 ms 1243.39 ms 4.43 ms
093a11f+dirty 1212.48 ms 1229.21 ms 16.73 ms

App size

Revision Plain With Sentry Diff
e62bf30+dirty 2.36 MiB 3.15 MiB 802.94 KiB
093a11f+dirty 2.36 MiB 3.10 MiB 752.44 KiB

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 8, 2024 •
edited
Loading

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1243.59 ms 1249.35 ms 5.76 ms
Size 2.92 MiB 3.66 MiB 757.78 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
abb7058+dirty 1260.28 ms 1266.56 ms 6.28 ms
e540498+dirty 1254.92 ms 1247.21 ms -7.71 ms
d43a46b+dirty 1223.31 ms 1230.92 ms 7.61 ms
0677344+dirty 1252.52 ms 1254.08 ms 1.56 ms
148f924+dirty 1220.72 ms 1221.30 ms 0.58 ms
700cbf4+dirty 1233.96 ms 1228.27 ms -5.69 ms
22e31b6+dirty 1276.55 ms 1278.12 ms 1.57 ms
5bb8d5f+dirty 1215.04 ms 1217.52 ms 2.48 ms
e73d82f+dirty 1231.20 ms 1228.81 ms -2.40 ms
70e6261+dirty 1224.90 ms 1231.02 ms 6.12 ms

App size

Revision Plain With Sentry Diff
abb7058+dirty 2.92 MiB 3.43 MiB 524.53 KiB
e540498+dirty 2.92 MiB 3.69 MiB 794.14 KiB
d43a46b+dirty 2.92 MiB 3.64 MiB 740.29 KiB
0677344+dirty 2.92 MiB 3.41 MiB 500.94 KiB
148f924+dirty 2.92 MiB 3.60 MiB 701.88 KiB
700cbf4+dirty 2.92 MiB 3.64 MiB 740.57 KiB
22e31b6+dirty 2.92 MiB 3.43 MiB 524.74 KiB
5bb8d5f+dirty 2.92 MiB 3.48 MiB 575.85 KiB
e73d82f+dirty 2.92 MiB 3.64 MiB 740.56 KiB
70e6261+dirty 2.92 MiB 3.59 MiB 686.11 KiB

Previous results on branch: antonis/add-breadcrumb-origin

Startup times

Revision Plain With Sentry Diff
e62bf30+dirty 1239.42 ms 1242.14 ms 2.73 ms
093a11f+dirty 1238.33 ms 1237.33 ms -1.01 ms

App size

Revision Plain With Sentry Diff
e62bf30+dirty 2.92 MiB 3.71 MiB 808.09 KiB
093a11f+dirty 2.92 MiB 3.66 MiB 757.73 KiB

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 10, 2024 •
edited
Loading

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 418.04 ms 467.87 ms 49.83 ms
Size 7.15 MiB 8.35 MiB 1.20 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
5bb8d5f+dirty 356.71 ms 389.65 ms 32.94 ms
80b2ce3+dirty 271.29 ms 316.47 ms 45.18 ms
acadc0f+dirty 259.04 ms 304.67 ms 45.63 ms
dadc233+dirty 363.19 ms 370.37 ms 7.18 ms
0db0c72+dirty 335.20 ms 351.06 ms 15.86 ms
9433f35+dirty 265.50 ms 336.08 ms 70.58 ms
8ae23a7+dirty 398.10 ms 411.48 ms 13.38 ms
1d86dd6+dirty 335.76 ms 371.22 ms 35.46 ms
e73d82f+dirty 377.67 ms 407.06 ms 29.39 ms
baa882f+dirty 449.30 ms 540.40 ms 91.10 ms

App size

Revision Plain With Sentry Diff
5bb8d5f+dirty 7.15 MiB 8.21 MiB 1.06 MiB
80b2ce3+dirty 7.15 MiB 8.04 MiB 911.02 KiB
acadc0f+dirty 7.15 MiB 8.03 MiB 903.20 KiB
dadc233+dirty 7.15 MiB 8.04 MiB 910.84 KiB
0db0c72+dirty 7.15 MiB 8.04 MiB 911.02 KiB
9433f35+dirty 7.15 MiB 8.08 MiB 959.34 KiB
8ae23a7+dirty 7.15 MiB 8.35 MiB 1.20 MiB
1d86dd6+dirty 7.15 MiB 8.13 MiB 1002.18 KiB
e73d82f+dirty 7.15 MiB 8.34 MiB 1.19 MiB
baa882f+dirty 7.15 MiB 8.34 MiB 1.19 MiB

Previous results on branch: antonis/add-breadcrumb-origin

Startup times

Revision Plain With Sentry Diff
093a11f+dirty 415.54 ms 461.00 ms 45.46 ms
e62bf30+dirty 369.36 ms 405.27 ms 35.92 ms

App size

Revision Plain With Sentry Diff
093a11f+dirty 7.15 MiB 8.35 MiB 1.20 MiB
e62bf30+dirty 7.15 MiB 8.39 MiB 1.24 MiB

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 11, 2024 •
edited
Loading

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 471.67 ms 487.81 ms 16.15 ms
Size 17.74 MiB 20.07 MiB 2.34 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
e73d82f 475.82 ms 506.55 ms 30.73 ms
0ebca77 414.93 ms 444.49 ms 29.56 ms
484813b 434.55 ms 452.31 ms 17.75 ms
e540498 436.26 ms 433.00 ms -3.26 ms
acadc0f+dirty 373.24 ms 381.51 ms 8.27 ms
70e6261 482.65 ms 495.70 ms 13.05 ms
b1e8712 462.11 ms 465.71 ms 3.60 ms
0677344 327.74 ms 337.14 ms 9.40 ms
3ffcddd 302.92 ms 315.80 ms 12.88 ms
728164b 414.34 ms 449.22 ms 34.88 ms

App size

Revision Plain With Sentry Diff
e73d82f 17.73 MiB 20.07 MiB 2.33 MiB
0ebca77 17.73 MiB 19.95 MiB 2.21 MiB
484813b 17.73 MiB 20.07 MiB 2.33 MiB
e540498 17.73 MiB 20.11 MiB 2.37 MiB
acadc0f+dirty 17.73 MiB 19.75 MiB 2.01 MiB
70e6261 17.73 MiB 19.94 MiB 2.21 MiB
b1e8712 17.73 MiB 19.75 MiB 2.02 MiB
0677344 17.73 MiB 19.81 MiB 2.07 MiB
3ffcddd 17.73 MiB 19.75 MiB 2.02 MiB
728164b 17.73 MiB 19.85 MiB 2.12 MiB

Previous results on branch: antonis/add-breadcrumb-origin

Startup times

Revision Plain With Sentry Diff
e62bf30 481.92 ms 471.48 ms -10.44 ms

App size

Revision Plain With Sentry Diff
e62bf30 17.73 MiB 20.11 MiB 2.38 MiB

@antonis
Merge branch 'main' into antonis/add-breadcrumb-origin
0e43c5d 
# Conflicts:
#	CHANGELOG.md
@antonis
Merge branch 'main' into antonis/add-breadcrumb-origin
8832cf9 
# Conflicts:
#	packages/core/android/src/main/java/io/sentry/react/RNSentryBreadcrumb.java
@antonis antonis mentioned this pull request Oct 15, 2024
Merged
@antonis
Merge branch 'main' into antonis/add-breadcrumb-origin
7a108ee 
# Conflicts:
#	CHANGELOG.md
#	packages/core/RNSentry.podspec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krystofwoldrich krystofwoldrich Awaiting requested review from krystofwoldrich krystofwoldrich will be requested when the pull request is marked ready for review krystofwoldrich is a code owner

@lucas-zimerman lucas-zimerman Awaiting requested review from lucas-zimerman lucas-zimerman will be requested when the pull request is marked ready for review lucas-zimerman is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exception capture context is overwritten by native scope sync
1 participant
@antonis