fix: Fix default auto-offset-reset value #5753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"error" is a dangerous value as it causes consumer to crash if partitions are scaled. This happened in INC-702. Let's always use "earliest" as the default.
nikhars
approved these changes
Apr 10, 2024
lynnagara
added a commit
to getsentry/sentry
that referenced
this pull request
Apr 11, 2024
Earliest is a safer default than latest. For example if we increase partition count in production, we need to start new partitions from the earliest point otherwise we run the risk of skipping messages. We will apply this default for all sentry consumers including the snuba ones: getsentry/snuba#5753 After this is merged, we can remove all the manually passed values in ops and use this default
lynnagara
added a commit
that referenced
this pull request
Apr 11, 2024
same idea as #5753 on the subscriptions consumers as well
c298lee
pushed a commit
to getsentry/sentry
that referenced
this pull request
Apr 12, 2024
Earliest is a safer default than latest. For example if we increase partition count in production, we need to start new partitions from the earliest point otherwise we run the risk of skipping messages. We will apply this default for all sentry consumers including the snuba ones: getsentry/snuba#5753 After this is merged, we can remove all the manually passed values in ops and use this default
lynnagara
added a commit
that referenced
this pull request
Apr 12, 2024
same idea as #5753 on the subscriptions consumers as well
lynnagara
added a commit
that referenced
this pull request
Apr 12, 2024
lynnagara
added a commit
that referenced
this pull request
Apr 17, 2024
lynnagara
added a commit
that referenced
this pull request
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"error" is a dangerous value as it causes consumer to crash if partitions are scaled. This happened in INC-702. Let's always use "earliest" as the default.