ref(api): parse pipeline tests, mql pipeline before treeify #5885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylemumma
commented
May 9, 2024
| @@ -33,8 +31,7 @@ | |||
|
|
|||
| def and_cond_repr(exp: Expression, visitor: ExpressionVisitor[str]) -> str: | |||
| assert isinstance(exp, FunctionCall) | |||
| conditions = get_first_level_and_conditions(exp) | |||
| parameters = ", ".join([arg.accept(visitor) for arg in conditions]) | |||
| parameters = ", ".join([arg.accept(visitor) for arg in exp.parameters]) | |||
There was a problem hiding this comment.
the way mapper was creating conditions did not reflect the structure of the query object, bc it was rebalancing
snuba/utils/pipeline_logger.py
Outdated
There was a problem hiding this comment.
this is a the class i used to capture intermediate values of the pipeline
tests/query/test_dsl_mapper.py
Outdated
There was a problem hiding this comment.
this reflects the new behavior of the mapper to not rebalance
|
cool title |
volokluev
reviewed
May 9, 2024
kylemumma
changed the title
volokluev
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major Changes