Draft: feat(gcp-kms): impersonate service account #1150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kevin Labesse <[email protected]>
eraac
changed the title
Signed-off-by: Kevin Labesse <[email protected]>
Signed-off-by: Kevin Labesse <[email protected]>
|
I got the same kind of issue from aws-profile #634 I want to use default application credential for encrypt (developpers credentials), and another one via impersonate for decrypt (CI). The current workaround is to edit encrypted file metadata, but isn't very conveniant ... But unfortunately, this change seems to be more complicated and I guess isn't related to this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of the possibility of impersonate service account to call the GCP KMS api.
I'm not 100% familiar with the project yet, I'm not sure I've done the work correctly, feel free to point my errors if any
For the unit tests, I guess I can probably add test for the sops metadata to ensure the
gcp_impersonate_service_accountis correctly set, but I need to be guide a bit here. Otherwise concerning the feature itself, I've no idea how to test it (except manually)I still have to update the README, I'll do this tomorrowdoneThanks for the review ❤️