Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text::LocaleDomain 1.32' __find_domain() Errors on Windows #7

Closed
theory opened this issue Oct 14, 2021 · 4 comments
Closed

Text::LocaleDomain 1.32' __find_domain() Errors on Windows #7

theory opened this issue Oct 14, 2021 · 4 comments

Comments

@theory
Copy link
Contributor

theory commented Oct 14, 2021

Looks like it was broken in 8c2b356, where I guess abs_path barfs when $found_dir is undef. For example, in this Sqitch test failure, it chokes on this bit of Cwd in Perl 5.16. Here's the stack trace:

# No such file or directory at C:/hostedtoolcache/windows/perl/5.16.3-thr/x64/site/lib/Locale/TextDomain.pm line 415.
#  at C:/hostedtoolcache/windows/perl/5.16.3-thr/x64/lib/Cwd.pm line 354.
# 	Cwd::_croak() called at C:/hostedtoolcache/windows/perl/5.16.3-thr/x64/lib/Cwd.pm line 630
# 	Cwd::fast_abs_path() called at C:/hostedtoolcache/windows/perl/5.16.3-thr/x64/site/lib/Locale/TextDomain.pm line 415
# 	Locale::TextDomain::__find_domain() called at C:/hostedtoolcache/windows/perl/5.16.3-thr/x64/site/lib/Locale/TextDomain.pm line 211
# 	Locale::TextDomain::__x() called at D:\a\sqitch\sqitch\lib/App/Sqitch/Command/add.pm line 224
# 	App::Sqitch::Command::add::configure() called at D:\a\sqitch\sqitch\lib/App/Sqitch/Role/ContextCommand.pm line 49
# 	App::Sqitch::Role::ContextCommand::__ANON__() called at (eval 341) line 1
# 	App::Sqitch::Command::add::__ANON__() called at (eval 343) line 2
# 	App::Sqitch::Command::add::configure() called at ./t/add.t line 144
# 	Test::Exception::throws_ok() called at ./t/add.t line 145
@Montclair
Copy link

I have this issue as well.

gflohr added a commit that referenced this issue Dec 2, 2022
@gflohr
possible solution for #7
3a0ab71
@gflohr
Copy link
Owner

gflohr commented Dec 2, 2022

Does 3a0ab71 fix the problem?

@Montclair
Copy link

It does for me, thanks! Please push to cpan.

@gflohr
Copy link
Owner

gflohr commented Dec 14, 2022

Fixed with 3a0ab71. Thanks for testing!

@gflohr gflohr closed this as completed Dec 14, 2022
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this issue May 20, 2023
@0-wiz-0
p5-Locale-libintl: update to 1.33.
3af8a0c 
Version 1.33 - 14 Dec 2020

* Bugs fixed:

  gflohr/libintl-perl#7
theory added a commit to sqitchers/sqitch that referenced this issue Jan 6, 2024
@theory
Use locale pragma instead of POSIX::set_locale()
5bbb856 
The Pragma is more likely to do the right thing, as confirmed by new
tests, which fail when using `setlocale` and now succeed with `use
locale`. The tests, in `xt/locale`, include compiled locale dictionaries
(`*.mo` files) with a single message for the tested languages. This is
in contrast to the released locale dictionaries, which are generated at
release time but not stored in the repository.

Update the `os.yml` and `perl.yml` workflows, which run all tests
including the new locale tests, to install the required locales on Linux
and to set the full `runs-on:` image name in the matrix (in response to
shogo82148/actions-setup-perl#1699).

Also remove the installation of an older version of Locale::TextDomain
from those workflows, since gflohr/libintl-perl#7 has been fixed and
released.

While at it, upgrade to `actions/checkout@v4` in all workflows and use
`runner.os` instead of `matrix.os` in conditionals.
@theory theory mentioned this issue Jan 6, 2024
Merged
theory added a commit to sqitchers/sqitch that referenced this issue Jan 6, 2024
@theory
Use locale pragma instead of POSIX::set_locale()
71ed858 
The Pragma is more likely to do the right thing, as confirmed by new
tests, which fail when using `setlocale` and now succeed with `use
locale`. The tests, in `xt/locale`, include compiled locale dictionaries
(`*.mo` files) with a single message for the tested languages. This is
in contrast to the released locale dictionaries, which are generated at
release time but not stored in the repository.

Update the `os.yml` and `perl.yml` workflows, which run all tests
including the new locale tests, to install the required locales on Linux
and to set the full `runs-on:` image name in the matrix (in response to
shogo82148/actions-setup-perl#1699).

Also remove the installation of an older version of Locale::TextDomain
from those workflows, since gflohr/libintl-perl#7 has been fixed and
released.

While at it, upgrade to `actions/checkout@v4` in all workflows and use
`runner.os` instead of `matrix.os` in conditionals.
theory added a commit to sqitchers/sqitch that referenced this issue Jan 6, 2024
@theory
Use locale pragma instead of POSIX::setlocale()
e548201 
The Pragma is more likely to do the right thing, as confirmed by new
tests, which fail when using `setlocale` and now succeed with `use
locale`. The tests, in `xt/locale`, include compiled locale dictionaries
(`*.mo` files) with a single message for the tested languages. This is
in contrast to the released locale dictionaries, which are generated at
release time but not stored in the repository.

Update the `Language-Team` header in the project localization packages
in `po` directory to `Sqitch Hackers <[email protected]>`.

Update the `os.yml` and `perl.yml` workflows, which run all tests
including the new locale tests, to install the required locales on Linux
and to set the full `runs-on:` image name in the matrix (in response to
shogo82148/actions-setup-perl#1699).

Also remove the installation of an older version of Locale::TextDomain
from those workflows, since gflohr/libintl-perl#7 has been fixed and
released.

While at it, upgrade to `actions/checkout@v4` in all workflows and use
`runner.os` instead of `matrix.os` in conditionals.
theory added a commit to sqitchers/sqitch that referenced this issue Jan 7, 2024
@theory
Use locale pragma instead of POSIX::setlocale()
f2cfc0d 
The Pragma is more likely to do the right thing, as confirmed by new
tests, which fail when using `setlocale` and now succeed with `use
locale`. The tests, in `xt/locale`, include compiled locale dictionaries
(`*.mo` files) with a single message for the tested languages. This is
in contrast to the released locale dictionaries, which are generated at
release time but not stored in the repository.

Update the `Language-Team` header in the project localization packages
in `po` directory to `Sqitch Hackers <[email protected]>`.

Update the `os.yml` and `perl.yml` workflows, which run all tests
including the new locale tests, to install the required locales on Linux
and to set the full `runs-on:` image name in the matrix (in response to
shogo82148/actions-setup-perl#1699).

Also remove the installation of an older version of Locale::TextDomain
from those workflows, since gflohr/libintl-perl#7 has been fixed and
released.

While at it, upgrade to `actions/checkout@v4` in all workflows and use
`runner.os` instead of `matrix.os` in conditionals.
theory added a commit to sqitchers/sqitch that referenced this issue Jan 7, 2024
@theory
Use locale pragma instead of POSIX::setlocale()
52d9d8d 
The Pragma is more likely to do the right thing, as confirmed by new
tests, which fail when using `setlocale` and now succeed with `use
locale`. The tests, in `xt/locale`, include compiled locale dictionaries
(`*.mo` files) with a single message for the tested languages. This is
in contrast to the released locale dictionaries, which are generated at
release time but not stored in the repository.

Update the `Language-Team` header in the project localization packages
in `po` directory to `Sqitch Hackers <[email protected]>`.

Update the `os.yml` and `perl.yml` workflows, which run all tests
including the new locale tests, to install the required locales on Linux
and to set the full `runs-on:` image name in the matrix (in response to
shogo82148/actions-setup-perl#1699).

Also remove the installation of an older version of Locale::TextDomain
from those workflows, since gflohr/libintl-perl#7 has been fixed and
released.

While at it, upgrade to `actions/checkout@v4` in all workflows and use
`runner.os` instead of `matrix.os` in conditionals.
theory added a commit to sqitchers/sqitch that referenced this issue Jan 8, 2024
@theory
Use locale pragma instead of POSIX::setlocale()
501759c 
The Pragma is more likely to do the right thing, as confirmed by new
tests, which fail when using `setlocale` and now succeed with `use
locale`. The tests, in `xt/locale`, include compiled locale dictionaries
(`*.mo` files) with a single message for the tested languages. This is
in contrast to the released locale dictionaries, which are generated at
release time but not stored in the repository.

Update the `Language-Team` header in the project localization packages
in `po` directory to `Sqitch Hackers <[email protected]>`.

Update the `os.yml` and `perl.yml` workflows, which run all tests
including the new locale tests, to install the required locales on Linux
and to set the full `runs-on:` image name in the matrix (in response to
shogo82148/actions-setup-perl#1699).

Also remove the installation of an older version of Locale::TextDomain
from those workflows, since gflohr/libintl-perl#7 has been fixed and
released.

While at it, upgrade to `actions/checkout@v4` in all workflows and use
`runner.os` instead of `matrix.os` in conditionals.
theory added a commit to sqitchers/sqitch that referenced this issue Jan 19, 2024
@theory
Use locale pragma instead of POSIX::setlocale()
5f93725 
The Pragma is more likely to do the right thing, as confirmed by new
tests, which fail when using `setlocale` and now succeed with `use
locale`. The tests, in `xt/locale`, include compiled locale dictionaries
(`*.mo` files) with a single message for the tested languages. This is
in contrast to the released locale dictionaries, which are generated at
release time but not stored in the repository.

Update the `Language-Team` header in the project localization packages
in `po` directory to `Sqitch Hackers <[email protected]>`.

Update the `os.yml` and `perl.yml` workflows, which run all tests
including the new locale tests, to install the required locales on Linux
and to set the full `runs-on:` image name in the matrix (in response to
shogo82148/actions-setup-perl#1699).

Also remove the installation of an older version of Locale::TextDomain
from those workflows, since gflohr/libintl-perl#7 has been fixed and
released.

While at it, upgrade to `actions/checkout@v4` in all workflows and use
`runner.os` instead of `matrix.os` in conditionals.
theory added a commit to sqitchers/sqitch that referenced this issue Jan 24, 2024
@theory
Use locale pragma instead of POSIX::setlocale()
633860b 
The Pragma is more likely to do the right thing, as confirmed by new
tests, which fail when using `setlocale` and now succeed with `use
locale`. The tests, in `xt/locale`, include compiled locale dictionaries
(`*.mo` files) with a single message for the tested languages. This is
in contrast to the released locale dictionaries, which are generated at
release time but not stored in the repository.

Update the `Language-Team` header in the project localization packages
in `po` directory to `Sqitch Hackers <[email protected]>`.

Update the `os.yml` and `perl.yml` workflows, which run all tests
including the new locale tests, to install the required locales on Linux
and to set the full `runs-on:` image name in the matrix (in response to
shogo82148/actions-setup-perl#1699).

Also remove the installation of an older version of Locale::TextDomain
from those workflows, since gflohr/libintl-perl#7 has been fixed and
released.

While at it, upgrade to `actions/checkout@v4` in all workflows and use
`runner.os` instead of `matrix.os` in conditionals.
theory added a commit to sqitchers/sqitch that referenced this issue Jan 24, 2024
@theory
Use locale pragma instead of POSIX::setlocale()
86a33b1 
The Pragma is more likely to do the right thing, as confirmed by new
tests, which fail when using `setlocale` and now succeed with `use
locale`. The tests, in `xt/locale`, include compiled locale dictionaries
(`*.mo` files) with a single message for the tested languages. This is
in contrast to the released locale dictionaries, which are generated at
release time but not stored in the repository.

Update the `Language-Team` header in the project localization packages
in `po` directory to `Sqitch Hackers <[email protected]>`.

Update the `os.yml` and `perl.yml` workflows, which run all tests
including the new locale tests, to install the required locales on Linux
and to set the full `runs-on:` image name in the matrix (in response to
shogo82148/actions-setup-perl#1699).

Also remove the installation of an older version of Locale::TextDomain
from those workflows, since gflohr/libintl-perl#7 has been fixed and
released.

While at it, upgrade to `actions/checkout@v4` in all workflows and use
`runner.os` instead of `matrix.os` in conditionals.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@theory @gflohr @Montclair