-
-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to layout item: JSHandle@node when cells have significant size #267
Comments
Paged.js has updated the logic to avoid infinite loop so now when the "layouter" cannot fit an element into the page, this element is left on the "invisible" column (on the right). If you open the developer tools on the HTML page, you can see the table on the right: And apparently Paged.js does not know how to break a cell but that's not an easy task! |
Automatically breaking up the cells is the full feature required to fix my issue. I understand this requires much more work so I think we should aim for a shorter term workaround. Diagnostic messages would help the author manually break up the cells. Currently, I only see a cryptic error with no information on the elements causing the problems.... and the document can be quite long... FYI, asciidoctor-pdf does not implement automatic cell break on page boundaries either. This is something I need to manually fix, which is a pity since it is dependent on the currently active template |
The error is a bit better on the developer console: I believe that our logger cannot create a string representation of a Node that's why we get
It should be possible to do it with Paged.js but as mentioned there are a few things to consider. |
We need to consider the target user profile, when troubleshooting:
|
That's a good idea but it probably won't be easy to infer the line number in the AsciiDoc document from the Paged.js error.
Yes that's a good idea. Here's the upstream issue for the table issue: https://gitlab.pagedmedia.org/tools/pagedjs/issues/227 I will look into the "Unable to find destination _a_section while generating PDF outline!" issue. |
It's related to the table bug, the PDF generated (by Chrome) does not contain the Dest entry for "_a_section". |
Also it happens when the table is very long and one page is not enough. As workaround I need to split the table and to fit manually the table "children" in different pages. |
I'm moving @dgslos comment here since it's related:
I will open a pull request to remove the message:
This message is misleading and the error is now fixed. I think we should replace it by:
What do you think? |
Hello,
I use the following on an up to date Ubuntu 19.10
The install log of asciidoctor-web-pdf was :
install.log
If I try to generate example.txt, I get this errors:
I have done a bit of testing, and if you comment the last "Lorem...", the error goes away. So I guess something is up with the layout of big cells...
The text was updated successfully, but these errors were encountered: