Resolves #37, write temporary file atomically #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thom4parisot
reviewed
Feb 2, 2019
| @@ -2,7 +2,7 @@ | |||
| const util = require('util') | |||
| const fs = require('fs') | |||
| const path = require('path') | |||
| const writeFile = util.promisify(fs.writeFile) | |||
| const writeFileAtomic = util.promisify(require('write-file-atomic')) | |||
There was a problem hiding this comment.
Promisification to be removed when npm/write-file-atomic#33 is addressed.
There was a problem hiding this comment.
And maybe not so soon because the module author is departing npm before it stops supporting Node@4 😢
There was a problem hiding this comment.
Yeah, I heard about the NPM layoffs 😞
There was a problem hiding this comment.
write-file-atomic@3 has been released with Promise support 👍
thom4parisot
approved these changes
Feb 2, 2019
|
Shouldn't be needed anymore because the processor is now taking care of writing the file in #33 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.