add-option-to-disable-k8s-client-cache #1210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calvix
commented
Nov 14, 2023
| KubeConfigPath string | ||
| TLS tls.TLS | ||
| Watch watch.Watch | ||
| } |
There was a problem hiding this comment.
this file was previously imported from operatorkit repo but since we need the extra property DisableClientCache string i redeclared it here
There was a problem hiding this comment.
I would normally ask to make the change in operatorkit, but since operatorkit is not developed and won't be used anymore soon I guess it's ok
There was a problem hiding this comment.
That was my thinking as well
whites11
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the client cache does not work for EKS as the kubeconfig is pretty short-lived (around 10-15 minutes) and the caching interval is 10 minutes as well so if the app-operator caches the kubeconfig very close to the EKS kubeconfig expiration then there is a situation that the app operator cannot work for several minutes, in E2E CI its around 5-8 minutes, this breaks e2e for EKS
towards giantswarm/roadmap#2820
I assume same thing affect the imported EKS clusters