Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds startupProbe for Kong Ingress Controller #179

Merged
merged 3 commits into from
Jan 18, 2022
Merged

Adds startupProbe for Kong Ingress Controller #179

merged 3 commits into from
Jan 18, 2022

Conversation

danibaeyens
Copy link
Contributor

  • This repository allows merge commits, if you're creating a Release, make sure to select 'Squash and merge'
  • When merging subtree updates, it is important to select 'Create a merge commit' when merging.

I'm not sure how you really manage your app versions vs upstream ones. Any comment will be welcomed.

@danibaeyens danibaeyens requested a review from a team as a code owner January 17, 2022 17:49
@ubergesundheit
Copy link
Member

Hello,

thanks for your contribution! I don't know why the CircleCI jobs do not run, I'll try to push some changes to your branch.

@ubergesundheit
Copy link
Member

Looks like tests still work 👍

I've pushed the following changes to your branch:

  • Restrict the Chart to be installed on clusters running 1.20 and above
  • Update the values schema

If you're fine with the changes, this would be ready from my side.

ubergesundheit
ubergesundheit approved these changes Jan 18, 2022
View reviewed changes
Copy link
Member

@ubergesundheit ubergesundheit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ubergesundheit ubergesundheit merged commit a11f0b1 into giantswarm:master Jan 18, 2022
@ubergesundheit
Copy link
Member

I'll craft a patch release now.

@danibaeyens
Copy link
Contributor Author

Amazing! Thanks a lot! :)

@ubergesundheit
Copy link
Member

Actually, this will be a minor. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ubergesundheit ubergesundheit ubergesundheit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danibaeyens @ubergesundheit