Minor per-request allocation reduction #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the middleware handler: the very first init of `l zerolog.Logger` does not yet depend on the request's `c *gin.Context`. It need not be allocated at the start of every request, since all later `l` usage happens anyway only after a new instance is allocated by `l.With`.
appleboy
approved these changes
Nov 28, 2023
|
@metaleap Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the middleware handler: the very first init of
l zerolog.Loggerdoes not yet depend on the request'sc *gin.Context. It need not be allocated at the start of every request, since all laterlusage happens anyway only after a new instance is allocated byl.With. With this change, it's inited-and-kept once pergin.Engine.