gpg signing is not working correctly

[slamp]

Version

0.12.27

Operating System

Mac OS X

Distribution Method

dmg (Apple Silicon)

Describe the issue

Hello,

I'm trying to sign with GPG my commit. In project settings I got the error: "gpg: signing failed: Inappropriate ioctl for device"
This could be solved by doing a export GPG_TTY=$TTY
I have the export in my .zshrc configuration

How to reproduce

MacOS Apple M2
gpg (GnuPG) 2.4.5
libgcrypt 1.10.3

Go to 'Project settings', click 'Git', enable 'Sign commits'
Define the 'signing program' to /opt/homebrew/bin/gpg
Click 'Test signing'

Expected behavior

GPG signing is working

Relevant log output

Signing is not working correctly
Failed to sign GPG:  [GNUPG:] KEY_CONSIDERED xxxxxxxx 2
[GNUPG:] BEGIN_SIGNING H10
[GNUPG:] PINENTRY_LAUNCHED 30528 curses 1.3.1 - - - - 502/20 0
gpg: signing failed: Inappropriate ioctl for device
[GNUPG:] FAILURE sign 83918950
gpg: signing failed: Inappropriate ioctl for device

[Byron]

Thanks for reporting!

Could you try to launch GitButler from a terminal window, for instance with /Applications/GitButler.app/Contents/MacOS/GitButler?

If that works, it's clearly an issue with GitButler, as windowed application, not seeing the necessary environment variables, which is a known issue.

Thanks for your help.

[slamp]

By launching GitButler in commandline, gpg asked me the Passphrase

and then I was able to sign a commit

So it works this way !

[Byron]

That's great to hear!

Thanks also for showing a screenshot, as it makes clear that the password entry is bound to having a terminal. So even if everything was configured correctly even without having all the environment variables, gpg would still be unable to query the password if there is no underlying terminal.

In order for GitButler to be handling this, it would somehow have to provide a terminal session to the programs Git may launch while creating commits - maybe that's possible somehow.

[Caleb-T-Owens]

Sorry for the inconvenience!

There are three action points here:

1. Investigate whether allowing the user to enter environment variables in the configuration could enable expert users to resolve situations like this on their own (perhaps there are some sensible defaults we can provide).
2. Investigate whether there is another set of environments we should be providing to prompt this gpg program to use our askpass setup
3. Document this work-around in our signing documentation page (good first issue).
4. As Byron suggests, perhaps we can detect that the signing program is waiting on something from STDIN, and open up a small shell prompt.