fix: clicking 'Cancel' on new project page does nothing #4671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixes gitbutlerapp#2539 - Clicking 'Add new project' immediately adds the the repo to the projects list - Clicking Cancel on the project setup pageredirects to the app root page - If the projects list conatins a project, the root page redirects to the project page. When the project setup is incomplete, the project setup is displayed - To avoid this redirect, clicking cancel now deletes the project
mtsgrd
reviewed
Aug 14, 2024
mtsgrd
reviewed
Aug 14, 2024
|
Thanks, this looks good. Would you mind fixing those lint errors and I'll merge this pr? |
|
Sure, sorry! |
mtsgrd
approved these changes
Aug 16, 2024
|
@mtsgrd is there any other action required from side before you merge? |
|
Sorry for the delay, no not at all. Let me rebase it and merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☕️ Reasoning
🧢 Changes
BackButtongeneric, added a callback (currently namedbeforeOnMouseDown) to be executed before the generic implementation of back.🎫 Affected issues
Fixes: #2539
📌 Todos
beforeOnMouseDownor replace with a different way to execute the deletionreloadis called only ifdeleteProjectdidn't throw, but in other places it's called anyway.