Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Started work / Stop Work History #1037

Closed
abitrolly opened this issue Apr 30, 2018 · 28 comments
Closed

Started work / Stop Work History #1037

abitrolly opened this issue Apr 30, 2018 · 28 comments

Comments

@abitrolly
Copy link
Contributor

abitrolly commented Apr 30, 2018

In multiformats/js-cid#38 (comment) I am pretty sure that the work was started by @dimkk 27 days ago, and I remember seeing it in gitcoin.co page too - https://gitcoin.co/issue/ipld/js-cid/38/121

But now @gitcoinbot edited its message to say that @rrandom is now working on the issue, although I don't see any activity from him. I also see that @gitcoinbot started to ping @rrandom in multiformats/js-cid#38 (comment) and it looks wrong, because there is no trace of history who started work on the issue, if he cancelled the work, no links to transactions - https://gitcoin.co/issue/ipld/js-cid/38/121

User Story

As a gitcoin.co user, I want to see history of changes on the bounty detail page, who worked on what, when started, when ended, so that I can reward people fairly.

Acceptance Criteria

  • The bounty detail page should show a history of who has started and stopped work
@owocki
Copy link
Contributor

owocki commented Apr 30, 2018

there is def a balance between providing the history of changes and clogging up the issue with a bunch of comments. we opted to avoid clogging up the issue with a bunch of comments..

perhaps we could have the gitcoin bounty show the start/stop work history.. would that suffcie @abitrolly

cc @mbeacom and @PixelantDesign on this

@abitrolly
Copy link
Contributor Author

start/stop history will help. I expected to see it on bounty page, but if it is exposed through API then there should be no problem for the bot to update its message like it does right now with some concise history format. It can also generate some d3.js pictures.

@abitrolly
Copy link
Contributor Author

But my biggest concern is that probably @dimkk never cancelled his work and @rrandom never started, so there is a bug on our side.

@owocki owocki changed the title Weird sync about Started work Weird sync about Started work / Stop Work May 8, 2018
@owocki owocki changed the title Weird sync about Started work / Stop Work Started work / Stop Work History May 8, 2018
@gitcoinbot
Copy link
Member

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 0.07 ETH (51.87 USD @ $741.02/ETH) attached to it.

@abitrolly
Copy link
Contributor Author

What if somebody could complete this earlier than in 4 weeks?

@zoek1
Copy link
Contributor

zoek1 commented May 12, 2018

@owocki as i undestand this will add a event model for record the activity of interested on each bounty right? I think the sunday send the PR with this functionality and one simple activity list on the bounty detail page

@zoek1
Copy link
Contributor

zoek1 commented May 13, 2018

I just pushed a WIP PR using the Interested model instead of create a new model for events.

@bohendo
Copy link

bohendo commented May 14, 2018

If two people show interest, should they both be shown under "Contributor" or only one at a time? I'm assuming we'll only display the first person to express interest who hasn't stopped working yet. Or maybe I don't need to touch that to solve this issue.

Also, why is there a many-to-many relationship between dashboard_interest and dashboard_bounty? Can one interest really be associated w more than one bounty?

@owocki
Copy link
Contributor

owocki commented May 15, 2018

@owocki as i undestand this will add a event model for record the activity of interested on each bounty right? I think the sunday send the PR with this functionality and one simple activity list on the bounty detail page

seems like that'd be a good approach to me! we could actually consolidate a lot of the events associated with bounties into this model!

@zoek1
Copy link
Contributor

zoek1 commented May 16, 2018

@owocki i've working on #925, this issue could take advantage of the activity model developed in such issue, we just need filtering the activity(start, work, stop work) on each given bounty. So I'll give priority to #925 and after i'll finish this, it's ok?

@owocki
Copy link
Contributor

owocki commented May 16, 2018

good call :)

@owocki
Copy link
Contributor

owocki commented May 16, 2018

@bohendo for the purposes of this ticket you can show all of the active interests that are in the DB on the frontend.

you can assume that someone else will handle the constraints on the number of of ppl who can express interest in #1098

@abitrolly
Copy link
Contributor Author

@owocki maybe just deploy https:/fedora-infra/datanommer and fedmsg to avoid reinventing event flow?

@gitcoinbot
Copy link
Member

@bohendo Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • warning (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@bohendo
Copy link

bohendo commented May 18, 2018

Oops, I expected to have more time to work on this during weekdays but that hasn't been the case. I'll ether dig into this & finish it over the weekend or hand it off to the next code monkey.

@bohendo
Copy link

bohendo commented May 20, 2018

Apologies, I won't be able to give this issue the attention it deserves.

@zoek1 Sounds like you've got a solid battle plan though, rock on & best of luck. The gitcoin bounty is available now if you want to take it: https://gitcoin.co/issue/gitcoinco/web/1037/394

@abitrolly
Copy link
Contributor Author

This is why started/stopped is important. ;)

@owocki
Copy link
Contributor

owocki commented May 21, 2018

thanks for letting us know @bohendo :)

how meta that this ticket is about start/stop work :)

@KennethAshley
Copy link
Contributor

Whats the latest on this? I'd love to knock it out.

@thelostone-mc
Copy link
Member

@zoek1 are you working on this ?

@vs77bb
Copy link
Contributor

vs77bb commented May 30, 2018

@KennethAshley This one is open on Gitcoin, feel free to snag whenever make sense 👍

@gitcoinbot
Copy link
Member

gitcoinbot commented Jun 9, 2018

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work has been started.

These users each claimed they can complete the work by 1 month ago. Please review their questions below:

  1. darkdarkdragon has started work.
  • Q: no questions for now

darkdarkdragon added a commit to darkdarkdragon/web that referenced this issue Jun 10, 2018
@darkdarkdragon darkdarkdragon mentioned this issue Jun 10, 2018
3 tasks
@gitcoinbot
Copy link
Member

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work for 0.07 ETH (36.68 USD @ $524.07/ETH) has been submitted by:

  1. @darkdarkdragon

@owocki please take a look at the submitted work:


@owocki
Copy link
Contributor

owocki commented Jun 13, 2018

testing the PR now

darkdarkdragon added a commit to darkdarkdragon/web that referenced this issue Jun 19, 2018
darkdarkdragon added a commit to darkdarkdragon/web that referenced this issue Jun 24, 2018
darkdarkdragon added a commit to darkdarkdragon/web that referenced this issue Jun 28, 2018
darkdarkdragon added a commit to darkdarkdragon/web that referenced this issue Jun 28, 2018
darkdarkdragon added a commit to darkdarkdragon/web that referenced this issue Jun 29, 2018
@owocki owocki closed this as completed Jul 6, 2018
@owocki owocki reopened this Jul 6, 2018
@abitrolly
Copy link
Contributor Author

This is called event sourcing http://microservices.io/patterns/data/event-sourcing.html

@gitcoinbot
Copy link
Member

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


The funding of 0.07 ETH (34.04 USD @ $486.33/ETH) attached to this issue has been approved & issued to @darkdarkdragon.

@owocki
Copy link
Contributor

owocki commented Jul 9, 2018

@darkdarkdragon one immediate issue i see is that the wrong person is listed as having submitted work on teh activity page for this bounty

https://gitcoin.co/issue/gitcoinco/web/1037/394

screenshot http://bits.owocki.com/3Y072p0j2M2V/Screen%20Shot%202018-07-08%20at%208.45.39%20PM.png

@darkdarkdragon
Copy link
Contributor

@owocki my mistake (
was not able to look at it earlier, but now I see you're already fixed it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants