feat: Test priority: "important"
and priority: "none"
notifications using Guidepup
#4
+682
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Part of https:/github/core-ux/issues/346 (requires Hubber login).
This PR adds a test for
priority: "important"
andpriority: "none"
notifications. The test is written using Guidepup and Playwright. It can be run withnpm test
.Below is a screen recording, with audio, of the test running (and passing). The “Suggested Text” example page is opened, and VoiceOver is started. The textarea is focused, and “a” is typed. The word “acceptable” is suggested as a completion, and the explanatory message “Press right arrow to commit suggestion” is conveyed too. The test validates these are conveyed.
Screen.Recording.2024-10-09.at.5.12.13.PM.mov
Next Steps
Footnotes
CI is the reason I opted to test in Edge. Edge is preinstalled on the
macos-latest
runners, so we’ll avoid downloading a browser in each CI run. ↩