Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add verilog to the topics #4488

Closed
wants to merge 4 commits into from
Closed

Conversation

mkfahim
Copy link

@mkfahim mkfahim commented Oct 13, 2024

Please confirm this pull request meets the following requirements:

  • I followed the contributing guidelines: https:/github/explore/blob/main/CONTRIBUTING.md.
  • I am not the sole author or employee of a company who created either the topic I am modifying/adding or the collection entry I am modifying/adding.

Which change are you proposing?

  • Suggesting edits to an existing topic or collection
  • Curating a new topic or collection
  • Something that does not neatly fit into the binary options above

Editing an existing topic or collection

I'm suggesting these edits to an existing topic or collection:

  • Image (and my file is *.png, square, dimensions 288x288, size <= 75 kB)
  • Content (and my changes are in index.md)

Please replace this line with an explanation of why you think these changes should be made.

Curating a new topic or collection

  • I've formatted my changes as a new folder directory, named for the topic or collection as it appears in the URL on GitHub (e.g. https:/topics/[NAME] or https:/collections/[NAME])
  • My folder contains a index.md
  • All required fields in my index.md conform to the Style Guide and API docs: https:/github/explore/tree/main/docs

Please replace this line with an explanation of why you think this topic or collection should be curated.

Something that does not neatly fit into the binary options above

  • My suggested edits are not about an existing topic or collection, or at least not a single one
  • My suggested edits are not about curating a new topic or collection, or at least not a single one
  • My suggested edits conform to the Style Guide and API docs: https:/github/explore/tree/main/docs

Please replace this line with an explanation of your proposed changes.

Changes Expected

  • A description to the verilog topic page so that developers can more easily learn about it.

@mkfahim mkfahim requested a review from a team as a code owner October 13, 2024 00:18
@mkfahim mkfahim changed the title Add verilog to the explore topics Add verilog to the topics Oct 13, 2024
Fix: Corrected topic metadata for Verilog

- Updated the topic name to be consistent with the directory name.
- Changed aliases to conform to format requirements.
- Revised the short description for clarity.

This commit resolves validation issues encountered during the build process.
@mkfahim mkfahim closed this Oct 13, 2024
@mkfahim
Copy link
Author

mkfahim commented Oct 13, 2024

Hello everyone,

I’ve realized that my pull request contains several mistakes and inconsistencies that need to be addressed. After careful consideration, I’ve decided to withdraw this pull request to ensure that I can provide a cleaner and more accurate contribution.

I appreciate your understanding and will work on correcting the issues before resubmitting. Thank you for your feedback so far!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant