[AB-0002]: google auth configuration simplified #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alexkucherenko is attempting to deploy a commit to the Listinai Team on Vercel. A member of the Team first needs to authorize it. |
OleksandrKucherenko
changed the title
|
Yeah i would like to solve the issue :) |
|
Hey @OleksandrKucherenko , a lot of these changes generally look good, but you're mixing a bunch of stuff up into a single PR. Could you please cherry pick the various changes into new branches and submit a PR per logical change, please? |
let's merge the PR #260 and than I will rebase this branch and it will make commits/changes much cleaner. |
jamesread
reviewed
Oct 2, 2024
|
As discussed on Discord, you're going to rebase this PR. |
OleksandrKucherenko
force-pushed
the
AB0002-google-auth-configuration
branch
from
3a82fb9
to
28572a4
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
OleksandrKucherenko
force-pushed
the
AB0002-google-auth-configuration
branch
3 times, most recently
from
c852d50
to
43fa27e
Compare
OleksandrKucherenko
force-pushed
the
AB0002-google-auth-configuration
branch
from
43fa27e
to
b88b97c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Why was this change needed?
Should be rebased and merged after this PR: #260