Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Improve Remove Icon and Toast Text Visibility in light mode #294

Conversation

JeevaRamanathan
Copy link
Contributor

@JeevaRamanathan JeevaRamanathan commented Oct 2, 2024

What kind of change does this PR introduce?

Bug fix

Why was this change needed?

Partially fixes #293

  • Remove Icon Color, Button text color
  • Toast text color

Other information:

Profile Settings (Before screenshots can be found here #293)
image
image

Toast
image

Copy link

vercel bot commented Oct 2, 2024

@JeevaRamanathan is attempting to deploy a commit to the Listinai Team on Vercel.

A member of the Team first needs to authorize it.

@bhargavshirin
Copy link

@JeevaRamanathan this issue is already solved by me

@nevo-david
Copy link
Contributor

Thank you!

@nevo-david nevo-david merged commit 3465b09 into gitroomhq:main Oct 3, 2024
0 of 2 checks passed
@JeevaRamanathan
Copy link
Contributor Author

Hi @bhargavshirin, Sorry for the confusion! I missed noticing your PR since the title was a bit too generic. My PR also addressed the visibility of both the remove icon and the toast text colors specifically for light mode.

Still a few more components need to be updated for better visibility in light mode—feel free to take any of them!
Happy contributing🎉!

@bhargavshirin
Copy link

My pr was closed 🥹👺

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Visual Inconsistency on Several Screens in Dark/Light Mode
3 participants