Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] [AB-0004]: extract svg files #370

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

OleksandrKucherenko
Copy link

What kind of change does this PR introduce?

Code improvement, extracting SVGs into own files.

Why was this change needed?

Extract assets into own files.

Other information:

#369

Checklist:

Put a "X" in the boxes below to indicate you have followed the checklist;

  • I have read the CONTRIBUTING guide.
  • I checked that there were not similar issues or PRs already open for this.
  • This PR fixes just ONE issue (do not include multiple issues or types of change in the same PR) For example, don't try and fix a UI issue and include new dependencies in the same PR.

Copy link

vercel bot commented Oct 15, 2024

@alexkucherenko is attempting to deploy a commit to the Listinai Team on Vercel.

A member of the Team first needs to authorize it.

return <OrderInProgress group={message?.id!} buyer={isBuyer} order={message?.orders[0]?.id!} />;
return (
<OrderInProgress
group={message?.id!}

Check warning

Code scanning / ESLint

Disallow non-null assertions using the `!` postfix operator Warning

Forbidden non-null assertion.
<OrderInProgress
group={message?.id!}
buyer={isBuyer}
order={message?.orders[0]?.id!}

Check warning

Code scanning / ESLint

Disallow non-null assertions using the `!` postfix operator Warning

Forbidden non-null assertion.
@OleksandrKucherenko OleksandrKucherenko changed the title [wip] AB0004: extract svg files [wip] [AB-0004]: extract svg files Oct 15, 2024
@nevo-david
Copy link
Contributor

Nice work! testing it!

@nevo-david
Copy link
Contributor

Started to check it, I already see some problem in the login
CleanShot 2024-10-16 at 13 19 49
I still see things that are not svg images, is it on purpose?
CleanShot 2024-10-16 at 13 21 34
CleanShot 2024-10-16 at 13 22 31

@OleksandrKucherenko
Copy link
Author

Nice work! testing it!

it's not done... Work In Progress

@OleksandrKucherenko OleksandrKucherenko force-pushed the AB0004-extract-svg-files branch 2 times, most recently from dc0af24 to 94fb1c5 Compare October 16, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants