Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove gleam version constraint #79

Merged
merged 2 commits into from
Sep 30, 2024
Merged

Remove gleam version constraint #79

merged 2 commits into from
Sep 30, 2024

Conversation

giacomocavalieri
Copy link
Member

This fixes a warning coming from the compiler, the project uses the @internal annotation but would allow gleam versions below 1.1. I removed the constraint altogether so the compiler will add the inferred one when published

@leonqadirie leonqadirie mentioned this pull request Sep 26, 2024
Closed
lpil
lpil reviewed Sep 28, 2024
View reviewed changes
Copy link
Member

@lpil lpil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put it back so people understand why the code doesn't compile if they use an older version of Gleam. 🙏

@giacomocavalieri
Copy link
Member Author

Done! Closes #77

lpil
lpil approved these changes Sep 30, 2024
View reviewed changes
Copy link
Member

@lpil lpil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@lpil lpil merged commit 73d0884 into gleam-lang:main Sep 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpil lpil lpil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@giacomocavalieri @lpil