Fix timezone handling #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Time zone in time format for JSON (un)marshaling is wrong. All dates used to be parsed in UTC. See numeric time zone offsets in: https://golang.org/pkg/time/#pkg-constants
…-timezone # Conflicts: # bson/json.go # bson/json_test.go
tadukurow
approved these changes
Jul 5, 2017
|
@domodwyer Sure no problem. My use case is a basic go tool that parses a mongo query written in JSON to run on a server where mongo cli is not available. The unmarshaller failed to parse my queries using non-UTC dates and I was surprised as well when I saw the time format used :) |
Merged
Closed
libi
pushed a commit
to libi/mgo
that referenced
this pull request
Dec 1, 2022
…son-timezone Fix timezone handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See go-mgo#464.
@reenjii I hope you don't mind us pulling it to our fork, it's a good catch - I'm pretty surprised this hasn't been noticed before! If you'd rather we didn't pull this, please let me know and we'll sort something out.
Thanks!