Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate read/write network timeouts #161

Merged
merged 9 commits into from
May 11, 2018

Commits on May 9, 2018

  1. socket: separate read/write network timeouts

    Splits DialInfo.Timeout (defaults to 60s when using mgo.Dial()) into ReadTimeout
    and WriteTimeout to address #160. Read/write timeout defaults to
    DialInfo.Timeout to preserve existing behaviour.
    domodwyer committed May 9, 2018
    Configuration menu
    Copy the full SHA
    775e6d7 View commit details
    Browse the repository at this point in the history
  2. cluster: remove AcquireSocket

    Only used by tests, replaced by the pool-aware acquire socket functions:
    	* AcquireSocketWithPoolTimeout
    	* AcquireSocketWithBlocking
    domodwyer committed May 9, 2018
    Configuration menu
    Copy the full SHA
    95f2333 View commit details
    Browse the repository at this point in the history
  3. cluster: use configured timeouts for cluster operations

    * `mongoCluster.syncServer()` no longer uses hard-coded 5 seconds
    * `mongoCluster.isMaster()` no longer uses hard-coded 10 seconds
    domodwyer committed May 9, 2018
    Configuration menu
    Copy the full SHA
    545befd View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    3b17aab View commit details
    Browse the repository at this point in the history
  5. server: fix fantastic serverTags nil slice bug

    When unmarshalling serverTags, it is now an empty slice, instead of a nil slice.
    
    `len(thing) == 0` works all the time, regardless.
    domodwyer committed May 9, 2018
    Configuration menu
    Copy the full SHA
    c0b9052 View commit details
    Browse the repository at this point in the history

Commits on May 11, 2018

  1. Configuration menu
    Copy the full SHA
    fbe8acd View commit details
    Browse the repository at this point in the history
  2. session: avoid calculating default values in hot path

    Changes `DialWithInfo` to handle setting default values by setting the relevant
    `DialInfo` field, rather than calling the respective methods in the hot path for:
    
    	* `PoolLimit`
    	* `ReadTimeout`
    	* `WriteTimeout`
    domodwyer committed May 11, 2018
    Configuration menu
    Copy the full SHA
    2573a57 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    716ee13 View commit details
    Browse the repository at this point in the history
  4. session: update docs

    domodwyer committed May 11, 2018
    Configuration menu
    Copy the full SHA
    22be2e3 View commit details
    Browse the repository at this point in the history