Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: need to remove pre-commit hooks #123

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

style: need to remove pre-commit hooks #123

wants to merge 1 commit into from

Conversation

sturoscy-personal
Copy link
Contributor

Sorry, I thought I created this PR before. Apparently not.

@sturoscy-personal
Copy link
Contributor Author

There should be two commits here. One for the functionality and one for the pre-commit. Its weird, the hook still ran and indicated changes to the file, but I don't see anything that is actually updated. Happy to do whatever to get this PR and commit message up to conventional commit standards.

@NickolausDS
Copy link
Contributor

You can try doing this to update your PR:

git commit --amend
# edit commit
git push -f refresh-file-listing

@NickolausDS
Copy link
Contributor

The changes themselves look good to me. I'll add an approval and you can merge when you fix the commit message.

@NickolausDS
Copy link
Contributor

Revisiting this old PR from last year, it looks like this adds a refresh button? @sturoscy-personal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickolausDS NickolausDS NickolausDS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sturoscy-personal @NickolausDS