Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jupyter-notebook needs json >= 1.5.0 #8

Open
lostbard opened this issue Dec 15, 2022 · 2 comments
Open

jupyter-notebook needs json >= 1.5.0 #8

lostbard opened this issue Dec 15, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@lostbard
Copy link

Octave 7 included json functions already so shouldnt need the json package as a dependancy

The json package also wont install due to the functions already available in octave.

@siko1056 siko1056 added the bug Something isn't working label Dec 16, 2022
@siko1056
Copy link
Member

This is true. I think Octave 7 is already wide spread enough to safely assume jsonencode and jsondecode are present in Octave. If not, a small help text could be provided.

@Abdallah-Elshamy are you interested in working on this?

@Abdallah-Elshamy
Copy link
Member

Abdallah-Elshamy commented Dec 19, 2022

@siko1056, I am interested. A simple solution for this would be simply to change the requirements to:

depends: octave (>= 7.1.0)

However this will not work for older versions' users that use the json package.

Another solution will be to remove depends and make the check in another place. I am not sure where is the best place to do so:

  • One simple place is at the constructor of the class by checking exist("jsonencode") but this will not prevent the package from being installed without the needed functions.
  • Another possible place is a package/pre_install.m script that does that. But, I am not sure if this kind of scripts is suitable for such checks as I did not use them before

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants