Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: config.in used undefined log level #7030

Merged
merged 1 commit into from
Dec 28, 2023

Conversation

marcusmueller
Copy link
Member

Description

As noticed by @argilo in #6673, this was a mistake. We shouldn't be using a log level string not defined in logger.cc.

Which blocks/areas does this affect?

logging!

Checklist

@willcode willcode added the Backport-3.10 Should be backported to 3.10 label Dec 28, 2023
Copy link
Member

@argilo argilo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this should preserve compatibility, since both the old and new loggers accept crit:

else if (nocase == "crit")
logger_set_level(logger, log4cpp::Priority::CRIT);

} else if (level == "crit" || level == "alert" || level == "fatal" ||
level == "emerg") {
parsed_level = spdlog::level::critical;

@willcode willcode merged commit 890fd15 into gnuradio:main Dec 28, 2023
14 checks passed
@argilo
Copy link
Member

argilo commented Jan 8, 2024

@willcode This might be a good one to include in 3.10.9.2 as well. Gqrx users are continuing to run into this: gqrx-sdr/gqrx#1316

@willcode willcode added ported-to-3.10 Has been ported to 3.10 and removed Backport-3.10 Should be backported to 3.10 labels Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
logging ported-to-3.10 Has been ported to 3.10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants