-
Notifications
You must be signed in to change notification settings - Fork 281
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
zeroing weak memory is now treated as weak memory since GC has been d…
…ropped
- Loading branch information
Showing
1 changed file
with
17 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 comments
on commit 5699959
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider the changes a work in progress ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
work in progress
Then it should not be in master, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a strong believer in getting improvements into master asap, and also in incremental improvement.
There's quite a lot of old code in base (most of which is fairly harmless), which should be cleaned up when we can do so without breaking backward compatibility.
Aren’t we effectively replacing
NSPointerFunctionsZeroingWeakMemory
withNSPointerFunctionsWeakMemory
above, and if so wouldn’t be sufficient to just check forNSPointerFunctionsWeakMemory
here and below?