Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change NSNumberFormatter minimum/maximum properties type #310

Merged
merged 1 commit into from
Aug 18, 2023

Conversation

triplef
Copy link
Member

@triplef triplef commented Aug 10, 2023

Not sure why they were defined as NSDecimalNumber, but in current Apple headers they are defined as NSNumber.

As far as I can tell these properties are not currently used in any implementations.

@triplef triplef requested a review from rfm as a code owner August 10, 2023 13:35
Copy link
Contributor

@rfm rfm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks fine to me.

@rfm rfm merged commit 446d168 into master Aug 18, 2023
9 checks passed
@triplef triplef deleted the fix-nsnumberformatter-api branch August 18, 2023 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants