chore: update linter (#2190)

go-acme · May 27, 2024 · 220c608 · 220c608
1 parent 92bde4c
commit 220c608
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 5 deletions.
diff --git a/.github/workflows/pr.yml b/.github/workflows/pr.yml
@@ -13,7 +13,7 @@ jobs:
  runs-on: ubuntu-latest
  env:
  GO_VERSION: stable
- GOLANGCI_LINT_VERSION: v1.58.1
+ GOLANGCI_LINT_VERSION: v1.59.0
  HUGO_VERSION: 0.117.0
  CGO_ENABLED: 0
  LEGO_E2E_TESTS: CI

diff --git a/.golangci.yml b/.golangci.yml
@@ -152,6 +152,10 @@ issues:
  - funlen
  - goconst
  - maintidx
+ - path: (.+)_test.go
+ text: 'Error return value of `fmt.Fprintln` is not checked'
+ linters:
+ - errcheck
  - path: providers/dns/dns_providers.go
  linters:
  - gocyclo

diff --git a/providers/dns/dynu/internal/client_test.go b/providers/dns/dynu/internal/client_test.go
@@ -106,7 +106,7 @@ func TestGetRootDomain(t *testing.T) {
 
  require.NoError(t, err)
 
- assert.NotNil(t, domain)
+ assert.NotNil(t, domain) //nolint:testifylint // false positive https:/Antonboom/testifylint/issues/95
  assert.Equal(t, test.expected.domain, domain)
  })
  }

diff --git a/providers/dns/rcodezero/internal/client_test.go b/providers/dns/rcodezero/internal/client_test.go
@@ -74,7 +74,7 @@ func TestClient_UpdateRecords_error(t *testing.T) {
 
  resp, err := client.UpdateRecords(context.Background(), "example.org", rrSet)
  require.ErrorAs(t, err, new(*APIResponse))
- assert.Nil(t, resp)
+ assert.Nil(t, resp) //nolint:testifylint // false positive https:/Antonboom/testifylint/issues/95
 }
 
 func TestClient_UpdateRecords(t *testing.T) {

diff --git a/providers/dns/servercow/internal/client_test.go b/providers/dns/servercow/internal/client_test.go
@@ -151,7 +151,7 @@ func TestClient_CreateUpdateRecord_error(t *testing.T) {
  msg, err := client.CreateUpdateRecord(context.Background(), "lego.wtf", record)
  require.Error(t, err)
 
- assert.Nil(t, msg)
+ assert.Nil(t, msg) //nolint:testifylint // false positive https:/Antonboom/testifylint/issues/95
 }
 
 func TestClient_DeleteRecord(t *testing.T) {
@@ -218,5 +218,5 @@ func TestClient_DeleteRecord_error(t *testing.T) {
  msg, err := client.DeleteRecord(context.Background(), "lego.wtf", record)
  require.Error(t, err)
 
- assert.Nil(t, msg)
+ assert.Nil(t, msg) //nolint:testifylint // false positive https:/Antonboom/testifylint/issues/95
 }