feat: support simplified issuance for very long domain names at Let's Encrypt #2054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as off-topic.
This comment was marked as off-topic.
|
I was confused by this change https:/go-acme/lego/pull/2054/files#diff-49d368acbbb16528a9b447c4cbb44c3901b0636333a15e42117bc5184a28ec5cR284 But this PR is incomplete, I will add the missing pieces. |
@ldez Can I help with the "missing pieces"? What exactly is missing? |
ldez
force-pushed
the
common-name-not-mandatory
branch
2 times, most recently
from
a1d2d95
to
882020a
Compare
ldez
force-pushed
the
common-name-not-mandatory
branch
from
882020a
to
e83ba8d
Compare
ldez
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's encrypt will support certificates without common name starting at 2023-11-29. Details see in this announcement. It allows to create certificates for domains longer than 64 characters without needing to set the common name to a shorter domain name.
This PR makes small adjustments to the certificate ordering to reflect the new possibility. The common name is only set if the first domain name is shorter or equal than 64 characters. Therefore the change should be compatible with the current usage.
Note: The new behaviour can already be tested on the staging server (https://acme-staging-v02.api.letsencrypt.org/directory)
Fixes #2049