-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
easydns: fix zone detection #2121
Conversation
Perfect. Will try it out tomorrow and provide feedback. Much appreciated. |
@thadius83 any news? |
No go unfortunately. Same results. Fresh build using - git clone [email protected]:ldez/lego.git when I use the the incorrect key I'm able to get error logs from easydns control panel which shows that it's not breaking the domain up correctly
Note my domain is 2 letters. When using the correct credentials, there is nothing recorded in the log file on the easydns side I suspect due to a parsing error, it's attempting to modify "id.au" rather than "XX.id.au" A successful log from them using acme.sh looks like this.
In the put command at 03:33:16, the content is
But it's submitting that put against |
Do you have checkout the branch (
My PR doesn't contain parsing: I replace the previous algorithm (based on split) by DNS calls. |
Can you try this call: https://sandbox.rest.easydns.net:3001/#/read/listZone with domain:
and give me JSON answers? |
lego version b7f0ca1 linux/amd64 I believe it's the correct version? |
OK, I just wanted to be sure because your message was ambiguous. Can you answer to this comment? #2121 (comment) |
I suspect I'm doing something wrong, the API under read doesn't have listZone Have tested the sandbox credentials and able to pull data via other commands? |
https://sandbox.rest.easydns.net/zones/records/all/test.xx.id.au {
"error": {
"code": 403,
"message": "Access to resource denied due to permissions"
}
} If I execute it on the parent domain it works, and dumps out the entire zone file. I've removed the other sub domains and parent domain info,
|
Have tried the last two commits you've made with no luck.. varying errors most recent
lego version f5edd67 linux/amd64 |
@thadius83 can you try with my new fix? |
Worked first time! Output in the easydns logs match the achme.sh shell script. Mind if I ask what the issue was, and are there any other tests or logs you want? I did test initially with the wrong credentials, and it returned the following - rather than the usual unauthorised message
|
With my latest commit, when using an invalid token you will have the API response:
Their messages are not clear, but it's not my fault 😄 |
haha no worries. I figured you might want to fix that just to be pedantic and avoid people like me questioning it! Thanks for the great work! |
Hi sorry to be the party pooper not sure how all this works inside out but I did
and still getting:
What am I doing wrong? Cheers! -AL |
The new implementation does a new call to get the zone, based on your log I think it's because your token doesn't have enough rights. |
@tsg1992 Can you open a new dedicated issue if the problem is not related to rights/permissions? In this new issue, can you provide the output of your lego with the env var |
Sure thanks for the quick reply @ldez . I'll open a new dedicated thread. It's not permission related, as I can create/renew other certificates wihtout issues. |
Fixes #1466