designate: allow manually overwriting DNS zone #2204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
changed the title
|
@ldez Thank you for refactoring! I'm not that fluent in golang :-) Is there anything else I should do or what is needed from me? |
Signed-off-by: Jan Dittrich <[email protected]>
ldez
force-pushed
the
feature/designateZoneName
branch
from
0a42bd1
to
739ddb5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is basically the same feature as in #1433 for the OpenStack Designate provider.
This solves problems that occur in situations like SplitDNS/Private DNS Zones where the automatic SOA detection might not work to the full extend. When setting the Zone Name via environment, it specifically uses this Zone Name when communicating with the Designate API. Otherwise, nothing changes.