Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(middleware/tracing): rename hump filename #2727

Merged
merged 1 commit into from
Mar 26, 2023

Conversation

demoManito
Copy link
Member

@demoManito demoManito commented Mar 13, 2023

Description (what this PR does / why we need it):

filename should not use hump
image

Which issue(s) this PR fixes (resolves / be part of):

Other special notes for the reviewers:

@demoManito demoManito changed the title fix(middleware/tracing): golang filename modify fix(middleware/tracing): rename filename Mar 18, 2023
@demoManito demoManito changed the title fix(middleware/tracing): rename filename fix(middleware/tracing): rename hump filename Mar 18, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 18, 2023

Codecov Report

Merging #2727 (3cbcb80) into main (9a973d2) will not change coverage.
The diff coverage is n/a.

❗ Current head 3cbcb80 differs from pull request most recent head f8628cc. Consider uploading reports for the commit f8628cc to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main    #2727   +/-   ##
=======================================
  Coverage   84.78%   84.78%           
=======================================
  Files          88       88           
  Lines        3891     3891           
=======================================
  Hits         3299     3299           
  Misses        418      418           
  Partials      174      174           
Impacted Files Coverage Δ
middleware/tracing/statshandler.go 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@demoManito demoManito force-pushed the fix/filename branch 2 times, most recently from ef158c0 to 06987fd Compare March 21, 2023 07:38
@daemon365 daemon365 added the LGTM label Mar 23, 2023
@shenqidebaozi shenqidebaozi merged commit f03f5f8 into go-kratos:main Mar 26, 2023
@demoManito demoManito deleted the fix/filename branch March 27, 2023 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants