refactor(metrics): replace kratos metrics with otel metrics #3256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:L
Ccheers
force-pushed
the
feat/otel-metrics
branch
6 times, most recently
from
47f2e6b
to
27ec122
Compare
dosubot
bot
added
size:M
Ccheers
force-pushed
the
feat/otel-metrics
branch
2 times, most recently
from
55e1ddb
to
27fb06b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3256 +/- ##
==========================================
+ Coverage 81.63% 82.02% +0.38%
==========================================
Files 91 92 +1
Lines 4166 4206 +40
==========================================
+ Hits 3401 3450 +49
+ Misses 587 578 -9
Partials 178 178 ☔ View full report in Codecov by Sentry. |
Ccheers
force-pushed
the
feat/otel-metrics
branch
2 times, most recently
from
b5cd836
to
da325ca
Compare
2 tasks
tonybase
previously approved these changes
Mar 19, 2024
daemon365
previously approved these changes
Mar 20, 2024
Ccheers
force-pushed
the
feat/otel-metrics
branch
3 times, most recently
from
1675d3f
to
b77380d
Compare
Ccheers
force-pushed
the
feat/otel-metrics
branch
from
b34c0a5
to
e666429
Compare
shenqidebaozi
changed the title
hawkingrei
previously approved these changes
Mar 22, 2024
Ccheers
force-pushed
the
feat/otel-metrics
branch
from
c0c0c90
to
e2e919d
Compare
dosubot
bot
added
size:L
Ccheers
force-pushed
the
feat/otel-metrics
branch
2 times, most recently
from
8839827
to
1f49be3
Compare
Ccheers
force-pushed
the
feat/otel-metrics
branch
from
1f49be3
to
690d1f7
Compare
hawkingrei
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (what this PR does / why we need it):
Which issue(s) this PR fixes (resolves / be part of):
#3255
Other special notes for the reviewers: