[WIP] fix: fix errors reported by Lint CI. #3435
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:S
mo3et
commented
Oct 10, 2024
| @@ -99,7 +99,6 @@ func (a *App) Run() error { | |||
| } | |||
| } | |||
| for _, srv := range a.opts.servers { | |||
| srv := srv | |||
There was a problem hiding this comment.
Kratos on fix/lint [!] via 🐹 v1.23.2
➜ golangci-lint run
app.go:102:3: The copy of the 'for' variable "srv" can be deleted (Go 1.22+) (copyloopvar)
srv := srv
^
fix error by copyloopvar. But this lint need change go version to 1.22 in Go.Mod. So i just run in local.
mo3et
commented
Oct 10, 2024
| @@ -31,6 +31,5 @@ jobs: | |||
| - name: Lint | |||
| uses: golangci/golangci-lint-action@v6 | |||
| with: | |||
| version: v1.60.3 | |||
| working-directory: ${{ matrix.workdir }} | |||
| skip-pkg-cache: true | |||
There was a problem hiding this comment.
skip-pkg-cache is remove in v5.0.0+.
mo3et
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (what this PR does / why we need it):
fix errors reported by Lint CI when this PR merged.
Which issue(s) this PR fixes (resolves / be part of):
This CI report need to use blank replace unused ctx. And CI config fields is deprecated. This PR is fix it.
Other special notes for the reviewers: