-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't set the transport's proxy settings to nil by default #39
Comments
neilotoole
changed the title
Don't override the transport's proxy settings
Don't set the transport's proxy settings to nil by default
Sep 30, 2016
Make sense. Yes, we can leave that to caller. Would you like to send PR? |
jeevatkm
added a commit
that referenced
this issue
Oct 2, 2016
Taken care. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In
client.go
, at this location, there's this code:The final
else
clause should be removed. If the caller provides atransport
, it may already have a proxy configured, there's no reason to set the transport's proxy tonil
.The text was updated successfully, but these errors were encountered: