This repository has been archived by the owner on Jun 25, 2022. It is now read-only.
check file is not a directory when returned as a file #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markbates
suggested changes
Jun 28, 2019
v2/jam/parser/finder.go
Outdated
| "github.com/gobuffalo/packr/v2/internal/takeon/github.com/markbates/errx" | ||
| "github.com/gobuffalo/packr/v2/internal/takeon/github.com/markbates/oncer" | ||
| "github.com/markbates/oncer" | ||
| "github.com/pkg/errors" |
There was a problem hiding this comment.
Th pkg/errors package has recently been removed from packr, can you please remove its use?
v2/jam/parser/finder.go
Outdated
| "path/filepath" | ||
| "strings" | ||
| "time" | ||
|
|
||
| "github.com/gobuffalo/packr/v2/plog" | ||
| "github.com/karrick/godirwalk" | ||
| "github.com/gobuffalo/packr/v2/internal/takeon/github.com/markbates/errx" | ||
| "github.com/gobuffalo/packr/v2/internal/takeon/github.com/markbates/oncer" | ||
| "github.com/markbates/oncer" |
There was a problem hiding this comment.
Can you please revert back to using the internal packages and not their external paths?
v2/jam/parser/finder.go
Outdated
| @@ -52,7 +64,7 @@ func (fd *finder) findAllGoFilesImports(dir string) ([]string, error) { | |||
| ctx := build.Default | |||
|
|
|||
| if len(ctx.SrcDirs()) == 0 { | |||
| err = fmt.Errorf("no src directories found") | |||
| err = errors.New("no src directories found") | |||
v2/jam/parser/finder.go
Outdated
| @@ -63,7 +75,7 @@ func (fd *finder) findAllGoFilesImports(dir string) ([]string, error) { | |||
|
|
|||
| if err != nil { | |||
| if !strings.Contains(err.Error(), "cannot find package") { | |||
| if _, ok := errx.Unwrap(err).(*build.NoGoError); !ok { | |||
|
changes are now made on the latest version. |
markbates
approved these changes
Jun 28, 2019
|
Thanks! I’ll do a release shortly. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for #203