🤔 Use Context in websocket Conn?

[hyingreborn]

Question description

Code snippet (optional)
main.go

package main

import "github.com/gofiber/fiber"

func main() {
  app := fiber.New()
  // JWTAuth is custom middleware, will use c.Local("claims") to store token claims in context
  app.Use(JWTAuth())
  app.Websocket("/ws", WSHandler)
}

wsHandler

func WSHandler(c *fiber.Conn) {
	for {
		mt, msg, err := c.ReadMessage()
		if err != nil {
			log.Println("read:", err)
			break
		}
		log.Printf("recv: %s", msg)
		// if this is a normal handler
		claims := c.Locals("claims").(*middleware.JwtClaims)
		msg = fmt.Sprintf("Hello! Your ID is: %s", claims.UserID)
		err = c.WriteMessage(mt, msg)
		if err != nil {
			log.Println("write:", err)
			break
		}
	}
}

[Fenny]

This is something that was on my mind when implementing websockets into fiber, we might move the Conn inside the Ctx (c.Conn) or pass an optional context handler in the callback (func(conn *Conn, ctx ...*Ctx). Ideas are welcome, I will do some testing this weekend. I will keep you updated 👍

[hyingreborn]

@Fenny Thanks a lot!

[Fenny]

Locals will be added to the Conn struct in v1.8.3. I will close this issue upon release.

[coderbuzz]

Just landed here, so Fiber has websockets support already? What ws lib is used? Most performed Gobwas/ws?

[koddr]

@coderbuzz hi!

Fiber use Fasthttp Websocket lib via middleware https:/gofiber/websocket

[coderbuzz]

@koddr hi,

Comes from NodeJS, in Node there is uWebSockets library which very perform.

http benchmark

WS

Sadly the author won't make the library available in Go. Based on benchmark above; Gobwas/ws seems most performed.

Curious any benchmark result for Fasthttp Websocket vs Gobwas/ws?

[Fenny]

@coderbuzz, In my opinion uWebSockets is currently only useful for route levels. When we talk about proper concurrency inside the request handler, the benchmarks don't lie.

Lets for example calculate 10 MD5 hashes (which is super fast) to simulate some processing that might happen:

wrk -t1 -c400 -d10s http://127.0.0.1:8080/

uWebsocketjs

// Thread Stats   Avg      Stdev     Max   +/- Stdev
// Latency     9.36ms    3.30ms  48.12ms   67.27%
// Req/Sec    43.02k     2.47k   47.12k    74.00%
const crypto = require('crypto');
const uws = require('uWebSockets.js');

var app = uws.App()
app.get('/*', (res, req) => {
  for (let i = 0; i < 10; i++) {
    const h = crypto.createHash('md5').update('foobar').digest('hex');
    if (h !== '3858f62230ac3c915f300c664312c63f') {
      throw h;
    }
  }
  res.end('Hello World!');
})
app.listen(8080, () => {});

Fiber

// Thread Stats   Avg      Stdev     Max   +/- Stdev
// Latency     2.82ms  363.98us   6.02ms   84.98%
// Req/Sec   140.72k     5.03k  148.43k    75.00%
package main

import (
  "crypto/md5"
  "encoding/hex"
  "github.com/gofiber/fiber"
)

func main() {
  app := fiber.New()
  app.Get("/", func(c *fiber.Ctx) {
    for i := 0; i < 10; i++ {
      b := md5.Sum([]byte("foobar"))
      h := hex.EncodeToString(b[:])
      if h != "3858f62230ac3c915f300c664312c63f" {
        panic(h)
      }
    }
    c.SendString("Hello, World!")
  })
  app.Listen(8080)
}

[Fenny]

@hyingreborn Locals are fixed in #224 using https:/gofiber/websocket

[kuchaguangjie]

So, what's the solution now ?

[kuchaguangjie]

Seems just use conn.Locals().