-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐞 routes that match a previously registered static file handler return a status code of 404 #250
Comments
y21
changed the title
🐞 routes that match a preivously registered static file handler return a status code of 404
🐞 routes that match a previously registered static file handler return a status code of 404
Mar 29, 2020
Merged
@y21, will be fixed in |
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Fiber version/commit
Fiber v1.8.42
Issue description
I'm not sure if this is a bug or intended behavior, but routes that match a previously registered static file handler will 404 (unless
ctx.Status
is explicitly called). I am aware that this can easily be avoided by simply registering a handler before registering static file handlers, but I don't think it should set a status code of 404 when there is a handler that matches the route.Expected behavior
If the route matches one of the registered handlers, it should not set the status code to 404. If this is indeed intended behavior, the handler function should not be called.
Steps to reproduce
~> Webserver responds with
test
, but returns a status code of 404.Code snippet
The text was updated successfully, but these errors were encountered: