Get mime fallback

[derkan]

Description

With current filesystem middleware, we don't let user to set custom content-type for a new extension when called from here. Becuse fiber's getMIME function uses statically defined mime types which cannot be changed.

This is needed when serving SPA project from emdedded filesystem where custom contet-types are needed. (i.e.sveltekit *.mjs file)

Fixes:

Allows fallback to golang's mime package for content-type detection. Because, go's default mime package allows setting custom mime types.

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

Checklist:

• For new functionalities I follow the inspiration of the express js framework and built them similar in usage
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation - https:/gofiber/docs for https://docs.gofiber.io/
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• If new dependencies exist, I have checked that they are really necessary and agreed with the maintainers/community (we want to have as few dependencies as possible)
• I tried to make my code as fast as possible with as few allocations as possible
• For new code I have written benchmarks so that they can be analyzed and improved

[welcome]

Thanks for opening this pull request! 🎉 Please check out our contributing guidelines. If you need help or want to chat with us, join us on Discord https://gofiber.io/discord

[gaby]

@derkan Some small errors showing up in the tests/lint

[gaby]

@derkan Are the tests passing locally for you?

[ReneWerner87]

please check the failed tests

[derkan]

@derkan Are the tests passing locally for you?

yes

[derkan]

problem is with go.1.16.

For the following code:

package main

import (
	"fmt"
	"mime"
)

func main() {
	fmt.Println("result:", mime.TypeByExtension(".text"))
}

• go.1.19 and go.1.20 this prints:

result: 

• go.1.16 prints:

result: text/plain; charset=utf-8

And because of this, Test_Ctx_Accepts fails for go.1.16 at line:

utils.AssertEqual(t, "json", c.Accepts("json", "text"))

[ReneWerner87]

https://expressjs.com/en/5x/api.html#req.accepts

we need a solution for this case
@derkan any ideas?

[derkan]

@ReneWerner87 a wrapper function(for making variadic - array type for mime names) around mime.ParseMediaType(...) can be enough? Playground

[ReneWerner87]

@gaby @leonklingele @efectn any ideas or opinions ?

[gaby]

@gaby @leonklingele @efectn any ideas or opinions ?

It's a nice feature to add. I'm confused as to why the tests dont' pass for go 1.16 though.

May be worth making sure our unit-tests match the expected results as shown in https://expressjs.com/en/5x/api.html#req.accepts

[leonklingele]

lgtm! 🚀

[gaby]

@derkan Can you update your branch with the latest changes in master. Trying to see if tests will pass.

[gaby]

CI is passing now!

[leonklingele]

It’s just flaky.

[ReneWerner87]

i have made a sync with the upstream, otherwise you don't see the real changes because of all the copies(144 files) of the changes from the masters

[welcome]

Congrats on merging your first pull request! 🎉 We here at Fiber are proud of you! If you need help or want to chat with us, join us on Discord https://gofiber.io/discord

[derkan]

Thank you all! 💯