Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📚 Docs: Fix typos, and make middleware documentation more consistent #2408

Merged
merged 2 commits into from Apr 10, 2023
Merged

📚 Docs: Fix typos, and make middleware documentation more consistent #2408

merged 2 commits into from Apr 10, 2023

Conversation

ghost
Copy link

@ghost ghost commented Apr 9, 2023

Description

This fixes several typos in the ISSUE_TEMPLATES, as well as making the middleware documentation markdowns more consistent

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation - /docs/ directory for https://docs.gofiber.io/

Commit formatting:

Use emojis on commit messages so it provides an easy way of identifying the purpose or intention of a commit. Check out the emoji cheatsheet here: https://gitmoji.carloscuesta.me/

This fixes several typos in the ISSUE_TEMPLATES, as well as improve
their readability, also makes the documentation markdowns more
consistent
@welcome
Copy link

welcome bot commented Apr 9, 2023

Thanks for opening this pull request! 🎉 Please check out our contributing guidelines. If you need help or want to chat with us, join us on Discord https://gofiber.io/discord

@gaby
Copy link
Member

gaby commented Apr 9, 2023

@cmd777 Can you fix the merge conflict?

Also removed a TODO comment from monitor.md
And fix a typo in timeout.md (depricated).. as well as put it in a
caution notice (to make it stand out more)
@ghost
Copy link
Author

ghost commented Apr 9, 2023

@gaby Yup, It should be OK now.

Also, I removed a TODO comment from the monitor.md (figured it's not really that necessary)
And fixed a typo in the new-new "timeout.md" (as well as making the notice that it's deprecated a caution warning, so that it can stand out)

@li-jin-gou li-jin-gou merged commit 8b1f926 into gofiber:master Apr 10, 2023
@welcome
Copy link

welcome bot commented Apr 10, 2023

Congrats on merging your first pull request! 🎉 We here at Fiber are proud of you! If you need help or want to chat with us, join us on Discord https://gofiber.io/discord

@ghost ghost mentioned this pull request Apr 12, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants