Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fix mount route positioning #2463

Merged
merged 5 commits into from
May 17, 2023
Merged

🐛 Fix mount route positioning #2463

merged 5 commits into from
May 17, 2023

Conversation

ReneWerner87
Copy link
Member

Description

Fixes #2460

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • For new functionalities I follow the inspiration of the express js framework and built them similar in usage
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I tried to make my code as fast as possible with as few allocations as possible

@ReneWerner87 ReneWerner87 requested review from efectn and gaby May 16, 2023 07:25
gaby
gaby approved these changes May 16, 2023
View reviewed changes
Copy link
Member

@gaby gaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one thing missing, but LGTM

mount_test.go Show resolved Hide resolved
leonklingele
leonklingele reviewed May 17, 2023
View reviewed changes
mount_test.go Outdated Show resolved Hide resolved
@ReneWerner87
Copy link
Member Author

ReneWerner87 commented May 17, 2023 •
edited
Loading

@gaby @leonklingele thx for the feedback

leonklingele
leonklingele reviewed May 17, 2023
View reviewed changes
mount_test.go Outdated Show resolved Hide resolved
@ReneWerner87 ReneWerner87 merged commit df87a82 into master May 17, 2023
@efectn efectn deleted the fix_mount_route_positioning branch June 9, 2023 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leonklingele leonklingele leonklingele left review comments

@gaby gaby gaby approved these changes

@efectn efectn Awaiting requested review from efectn

Assignees
No one assigned
Labels
☢️ Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 [Bug]: Wrong handlers execution order in some mount cases
3 participants
@ReneWerner87 @gaby @leonklingele