🩹 Fix: default logger color behaviour #2513
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#2493 introduces DisableColors, but it's default value is set to true, which contradicts the documentation:
https://docs.gofiber.io/api/middleware/logger#config
https://docs.gofiber.io/api/middleware/logger#default-config, as well as https:/gofiber/fiber/blob/master/middleware/logger/config.go#L94
and therefore, coloring is disabled by default, and can only be enabled by explicitly setting DisableColors to false
Type of change
Checklist:
Commit formatting:
Use emojis on commit messages so it provides an easy way of identifying the purpose or intention of a commit. Check out the emoji cheatsheet here: https://gitmoji.carloscuesta.me/