Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝 Added Egyptian Arabic readme file #2565

Merged
merged 5 commits into from
Aug 17, 2023

Conversation

scandar
Copy link
Contributor

@scandar scandar commented Aug 8, 2023

Description

  • Adds Egyptian Arabic readme
  • Adds links to the newly created readme in other readmes

Type of change

Please delete options that are not relevant.

  • This change requires a documentation update

Checklist:

  • For new functionalities I follow the inspiration of the express js framework and built them similar in usage
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation - /docs/ directory for https://docs.gofiber.io/
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • If new dependencies exist, I have checked that they are really necessary and agreed with the maintainers/community (we want to have as few dependencies as possible)
  • I tried to make my code as fast as possible with as few allocations as possible
  • For new code I have written benchmarks so that they can be analyzed and improved

@welcome
Copy link

welcome bot commented Aug 8, 2023

Thanks for opening this pull request! 🎉 Please check out our contributing guidelines. If you need help or want to chat with us, join us on Discord https://gofiber.io/discord

@ReneWerner87
Copy link
Member

@scandar can you solve the conflict, have in between another smaller change gemerged, which you have probably corrected with

@scandar
Copy link
Contributor Author

scandar commented Aug 9, 2023

@ReneWerner87 Fixed it, thanks for pointing it out.

@ReneWerner87
Copy link
Member

@gofiber/contributors can anyone speak arabic and check this?

@ReneWerner87 ReneWerner87 merged commit bd9c3fc into gofiber:master Aug 17, 2023
1 check passed
@welcome
Copy link

welcome bot commented Aug 17, 2023

Congrats on merging your first pull request! 🎉 We here at Fiber are proud of you! If you need help or want to chat with us, join us on Discord https://gofiber.io/discord

@scandar
Copy link
Contributor Author

scandar commented Aug 17, 2023

It looks like github can't load long SVG URIs. it's returning a 414 status code for the new Egyptian flag image.
@ReneWerner87 do you know where to get smaller flags similar to the ones used in the docs?

@ReneWerner87
Copy link
Member

hmm not really, had tried it too
unfortunately the svg is quite complex, you probably have to make it simpler first

@ReneWerner87
Copy link
Member

it is working without the eagle
85d1f68

@scandar
Copy link
Contributor Author

scandar commented Aug 17, 2023

without the eagle

That's the yemeni flag but i guess it's fine :D

@ReneWerner87
Copy link
Member

unfortunately the eagle is too complex with too many lines so it produces a large svg
if you can make this eagle simpler, feel free to replace it

@scandar scandar deleted the eg-arabic-readme branch August 18, 2023 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants