Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/pgsql add pgsql unit test #1853

Merged
merged 10 commits into from
May 23, 2022
Merged

Feature/pgsql add pgsql unit test #1853

merged 10 commits into from
May 23, 2022

Conversation

chaggle
Copy link
Contributor

@chaggle chaggle commented May 18, 2022

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented May 18, 2022 •
edited
Loading

Codecov Report

Merging #1853 (d129ab5) into feature/pgsql (583d576) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head d129ab5 differs from pull request most recent head 974d994. Consider uploading reports for the commit 974d994 to get more accurate results

@@                Coverage Diff                @@
##           feature/pgsql    #1853      +/-   ##
=================================================
- Coverage          71.20%   71.18%   -0.02%     
=================================================
  Files                463      463              
  Lines              43534    43534              
=================================================
- Hits               30997    30990       -7     
- Misses             10561    10568       +7     
  Partials            1976     1976
Flag Coverage Δ
go-1.15 71.15% <ø> (-0.02%) ⬇️
go-1.16 71.14% <ø> (-0.06%) ⬇️
go-1.17 71.14% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
os/gspath/gspath_cache.go 84.21% <0.00%> (-10.53%) ⬇️
os/gcron/gcron_z_unit_schedule.go 67.09% <0.00%> (-0.43%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 583d576...974d994. Read the comment docs.

@chaggle chaggle mentioned this pull request May 18, 2022
Closed
gqcn
gqcn requested changes May 18, 2022
View reviewed changes
contrib/drivers/pgsql/pgsql_db_test.go Show resolved Hide resolved
contrib/drivers/pgsql/pgsql_init_test.go Outdated
"fmt"

_ "github.com/gogf/gf/contrib/drivers/pgsql/v2"
_ "github.com/lib/pq"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

github.com/lib/pq在github.com/gogf/gf/contrib/drivers/pgsql/v2中已经引用，这里不需要再显式引用。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@chaggle chaggle added the done This issue is done, which may be release in next version. label May 19, 2022
gqcn
gqcn requested changes May 19, 2022
View reviewed changes
contrib/drivers/pgsql/pgsql.go Outdated
"user=%s password=%s host=%s port=%s dbname=%s sslmode=disable",
config.User, config.Pass, config.Host, config.Port, config.Name,
"user=%s password=%s host=%s port=%s sslmode=disable",
config.User, config.Pass, config.Host, config.Port,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里不能去掉数据库名称配置，会引起数据库名称配置失效。
如果不想连接特定数据库，尝试设置数据库名称为空试试。

@gqcn gqcn merged commit 23b7c93 into gogf:feature/pgsql May 23, 2022
@chaggle chaggle removed the done This issue is done, which may be release in next version. label May 27, 2022
gqcn pushed a commit that referenced this pull request Jul 7, 2022
@chaggle
Feature/pgsql add pgsql unit test (#1853) (#1973)
afb90b0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gqcn gqcn gqcn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chaggle @codecov-commenter @gqcn