Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/gfcli: replace gofmt&goimports with tools/imports #1935

Merged
merged 1 commit into from
Jun 24, 2022

Conversation

BeanWei
Copy link
Contributor

@BeanWei BeanWei commented Jun 24, 2022

golang.org/x/tools/imports 替换 gofmt&goimports

@codecov-commenter
Copy link

codecov-commenter commented Jun 24, 2022

Codecov Report

Merging #1935 (b49e017) into master (19779cd) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1935   +/-   ##
=======================================
  Coverage   75.56%   75.57%           
=======================================
  Files         512      512           
  Lines       46373    46373           
=======================================
+ Hits        35041    35045    +4     
+ Misses       9328     9323    -5     
- Partials     2004     2005    +1     
Flag Coverage Δ
go-1.15-386 75.46% <ø> (-0.03%) ⬇️
go-1.15-amd64 75.46% <ø> (-0.01%) ⬇️
go-1.16-386 75.48% <ø> (+0.01%) ⬆️
go-1.16-amd64 75.47% <ø> (-0.01%) ⬇️
go-1.17-386 75.54% <ø> (+0.06%) ⬆️
go-1.17-amd64 75.51% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
os/gfsnotify/gfsnotify_filefunc.go 74.02% <0.00%> (-3.90%) ⬇️
os/gfsnotify/gfsnotify_watcher_loop.go 83.19% <0.00%> (+2.52%) ⬆️
os/gcache/gcache_adapter_memory_lru.go 97.91% <0.00%> (+8.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19779cd...b49e017. Read the comment docs.

@gqcn gqcn merged commit 0503c17 into gogf:master Jun 24, 2022
@BeanWei BeanWei deleted the feature/improve-gfcli-goimports-and-gofmt branch June 27, 2022 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants